Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pipe-based notifier to epoll #134

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add a pipe-based notifier to epoll #134

merged 2 commits into from
Aug 16, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Aug 10, 2023

In some containers, eventfd is not available as it cannot be implemented securely in some hosts. This commit adds a fallback notifier that uses a pipe instead of eventfd.

Closes #122

Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In some containers, eventfd is not available as it cannot be implemented
securely in some hosts. This commit adds a fallback notifier that uses
a pipe instead of eventfd.

Closes #122

Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
@notgull notgull merged commit 2c279b8 into master Aug 16, 2023
24 checks passed
@notgull notgull deleted the notgull/pipe-in-epoll branch August 16, 2023 15:34
@notgull notgull mentioned this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a fallback to Linux to avoid eventfd if it fails on Gramine
2 participants