feat: enable construct event constantly #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps I can use a Keep this PR open for ideas on whether we can make the event constructors themselves const. |
notgull
requested changes
Aug 22, 2023
Comment on lines
655
to
657
| EventExtra { | ||
| flags: AfdPollMask::empty(), | ||
| } |
There was a problem hiding this comment.
Fix the compile error by also making AfdPollMask::empty() constant.
| @@ -186,7 +186,7 @@ impl Event { | |||
| /// All kinds of events (readable and writable). | |||
| /// | |||
| /// Equivalent to: `Event { key, readable: true, writable: true }` | |||
| pub fn all(key: usize) -> Event { | |||
| pub const fn all(key: usize) -> Event { | |||
There was a problem hiding this comment.
You forgot to make the poll.rs version of EventEmpty const.
Signed-off-by: tison <[email protected]>
|
Updated at here. Let's see if all the empty branches can be |
|
All tests passed. PTAL @notgull |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe #133 can prevent this from being possible; since it includes sys details for
Event.These
systhings are one of the main complain onmiothat I want to get rid of.Compare with
mio, it can obtain aconst TOKEN: Token = Token(0), while inpollingwe cannot obtain a const interestEventlikeconst INTEREST: Event = Event::readable(1). I don't want to know about thesysthings.cc @notgull