feat : add the ability to identify if tcp connection has failed #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Jan 25, 2024
src/kqueue.rs
Outdated
|
|
||
| #[inline] | ||
| pub fn is_connect_failed(&self) -> bool { | ||
| unimplemented!("is connect failed is not supported on kqueue"); |
There was a problem hiding this comment.
Just return false here, no need to panic
There was a problem hiding this comment.
updated
examples/tcp_client.rs
Outdated
Comment on lines
22
to
25
| let Some(event) = event else { | ||
| println!("no event"); | ||
| return Ok(()); | ||
| }; |
There was a problem hiding this comment.
Is this syntax compatible with Rust 1.63?
There was a problem hiding this comment.
updated
| /// | ||
| /// This indicates a tcp connection has failed, it corresponds to the `EPOLLERR` along with `EPOLLHUP` event in linux | ||
| /// and `CONNECT_FAILED` event in windows IOCP. | ||
| /// |
There was a problem hiding this comment.
added
src/poll.rs
Outdated
Comment on lines
432
to
434
| // need reviewer's special attention, as I do not have access to a system that supports this | ||
| // this is a guess based on the documentation of `poll()` | ||
| self.flags.contains(PollFlags::ERR) || self.flags.contains(PollFlags::HUP) |
|
Actually, I think it might be a saner model to have it return |
You mean for is_connect_failed? do we still need supports_is_connect_failed in this case? |
|
Yes, that's right. No we do not. |
irvingoujAtDevolution
force-pushed
the
master
branch
from
808428d
to
3144404
Compare
updated! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added is_connection_failed method to identify if a tcp connection has failed, please see example
tcp_client.rs.Let me know if adding socket2 to dev-dependency is acceptable, I will remove it if not.
address #184