-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gimp #242
bump gimp #242
Conversation
The build seems to be failing on arm. @popey or @lucyllewy, do you want to continue to get the latest version at least on amd64, or do you want to fix the arm64 issues first? |
I'm stumped. I don't have an arm64 machine in which to test this. @lucyllewy any ideas?
I can't fathom where that Also, a datapoint: according to the store stats, around 0.2% of users are on the arm64 build. 99.4% are on amd64. |
I can fix this. We can simply use |
@popey if you help me a little more, I guess my current manifest is in the shape of working, and it's also in core22. We can make it work. |
@soumyaDghosh, let's continue the conversation about your work on your PR, as it's quite a comprehensive change. For this PR, which I'm doing minor changes to get 2.10.34 out the door, I have rolled back the version of libaom to a version I know used to build on core20, so it builds on arm64. I have test-built this in Launchpad. It gets past libaom, so I am somewhat confident this will build in the GitHub action. So I have pushed this one-line change to get it building. Let's see if this works, and if it does, get this merged so we get 2.10.34 built in edge, and can test it. |
This failed build is a lie and we should not trust it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting in all this work, @popey!
This updates gimp to the latest release.
Had to update git URLs for gmic as it's moved.
They also stopped supporting cmake, so switched to qmake.