Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gimp, migrate to core24 #281

Merged
merged 13 commits into from
Sep 8, 2024
Merged

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Sep 5, 2024

This is a bit of maintenance to ensure we're ready when GIMP 3.0 releases.

  • Bumps gmic, which enables us to drop a patch I wrote last time
  • Bumps rawtherapee, enabling us to drop another patch!
  • Grab gimp from master for now, but moving to 2.99.19-rc soon

Edit: subsequent patches...

  • Drop rawtherapee
  • Use libwmf & ghostscript from the archive
  • Cleanup some explicit things taken care of by the gnome extension
  • Remove evince (I can't see why we're shipping this in the snap?)

Edit (again!):

  • Migrate to core24 and use more libraries from the archive

lucyllewy
lucyllewy previously approved these changes Sep 5, 2024
Copy link
Member

@lucyllewy lucyllewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 5, 2024

Some updates (I've edited the PR description):

  • Drop rawtherapee
  • Use libwmf & ghostscript from the archive
  • Cleanup some explicit things taken care of by the gnome extension
  • Remove evince (I can't see why we're shipping this in the snap?)

lucyllewy
lucyllewy previously approved these changes Sep 5, 2024
Copy link
Member

@lucyllewy lucyllewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunvonlope
Copy link

Remove evince (I can't see why we're shipping this in the snap?)

@jnsgruk This dep is there probably because of the custom print preview

@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 5, 2024

Remove evince (I can't see why we're shipping this in the snap?)

@jnsgruk This dep is there probably because of the custom print preview

Ah interesting. I'll update to just stage it from the archive then.

@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 6, 2024

This built, but didn't actually run due to a mismatch in libharfbuzz versions. I'm in the process of migrating the snap to 24.04, which should fix that.

@jnsgruk jnsgruk marked this pull request as draft September 6, 2024 16:23
@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 6, 2024

Updated to core24, but broke gmic in the process, will attempt to fix that next. So far these changes have made quite a nice simplification to the codebase, and also reduced the size of the snap by over 300MB!

@jnsgruk jnsgruk changed the title Update gimp, rawtherapee, gmic Update gimp, migrate to core24 Sep 6, 2024
@jnsgruk jnsgruk force-pushed the update-deps branch 4 times, most recently from 9850003 to a0544dc Compare September 6, 2024 20:31
@jnsgruk jnsgruk force-pushed the update-deps branch 7 times, most recently from 05a6291 to 7a2f17a Compare September 6, 2024 21:31
@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 6, 2024

Last little hurdle now before this is ready! I get this error when I try to start Gmic...

image

If anyone knows how to solve this, I'm all ears... perhaps @kenvandine or @sergiusens?

@jnsgruk jnsgruk force-pushed the update-deps branch 3 times, most recently from 7c4ee0a to 30f6ebb Compare September 8, 2024 14:57
@jnsgruk
Copy link
Member Author

jnsgruk commented Sep 8, 2024

G'mic working! Will merge this so that a candidate build gets pushed that can be tested more easily by folks!

image

@jnsgruk jnsgruk marked this pull request as ready for review September 8, 2024 15:01
@jnsgruk jnsgruk merged commit 266b236 into snapcrafters:preview Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants