Fix Issues from Previous Pull Request

.github/workflows/ci.yaml

@@ -7,20 +7,25 @@
      name: lint
      runs-on: ubuntu-latest
      steps:
-       - uses: actions/checkout@v2
-       - name: golangci-lint
-         uses: golangci/golangci-lint-action@v2
-         with:
-           version: latest
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.22'
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: v1.58
    test:
      name: test
      runs-on: ubuntu-latest
      steps:
-       - uses: actions/checkout@v2
-       - uses: actions/setup-go@v2
+       - uses: actions/checkout@v4
+       - uses: actions/setup-go@v4
          with:
            go-version: 1.22
        - run: go test -v ./... -covermode=atomic -coverprofile=coverage.out
-       - uses: codecov/codecov-action@v1
+       - uses: codecov/codecov-action@v4.0.1
          with:
-           files: coverage.out
+           files: coverage.out
+           token: ${{ secrets.CODECOV_TOKEN }}
+           slug: snapp-incubator/nats-blackbox-exporter

.gitignore

@@ -18,4 +18,6 @@
 .idea/
 
 # config
-config.yaml
+config.yaml
+
+.DS_Store

.golangci.yml

@@ -1,27 +1,8 @@
-# ---
-# linters:
-#   enable-all: true
-#   disable:
-#     - depguard
-#     # we don't use json with camel-case
-#     - tagliatelle
-#     - nolintlint
-#     # it should improve to support more known patterns
-#     - varnamelen
-#     - ireturn
-#     # deprecated linters
-#     - maligned
-#     - scopelint
-#     - golint
-#     - ifshort
-#     - interfacer
-#     - exhaustivestruct
-#     - nosnakecase
-#     - varcheck
-#     - deadcode
-#     - structcheck
-#     - gomnd
-#     - execinquery
-#     # temporarily disabled 
-#     - tagalign
-#     - gochecknoglobals
+---
+linters:
+  enable:
+    - gofmt   
+    - govet  
+    - revive 
+    - staticcheck 
+    - errcheck

internal/cmd/main.go

@@ -5,17 +5,17 @@ import (
 	"os/signal"
 	"syscall"
 
-	"github.com/snapp-incubator/nats-blackbox-exporter/internal/client"
 	"github.com/snapp-incubator/nats-blackbox-exporter/internal/config"
+	"github.com/snapp-incubator/nats-blackbox-exporter/internal/natsclient"
 	"go.uber.org/zap"
 )
 
 func main(cfg config.Config, logger *zap.Logger) {
 	natsConfig := cfg.NATS
 
-	natsClient := client.New(client.Connect(logger, natsConfig), logger, natsConfig)
+	client := natsclient.New(natsclient.Connect(logger, natsConfig), logger, natsConfig)
 
-	natsClient.StartMessaging()
+	client.StartMessaging()
 
 	sig := make(chan os.Signal, 1)
 	signal.Notify(sig, syscall.SIGINT, syscall.SIGTERM)

internal/config/config.go

@@ -10,8 +10,8 @@ import (
 	"github.com/knadh/koanf/providers/file"
 	"github.com/knadh/koanf/providers/structs"
 	"github.com/knadh/koanf/v2"
-	"github.com/snapp-incubator/nats-blackbox-exporter/internal/client"
 	"github.com/snapp-incubator/nats-blackbox-exporter/internal/logger"
+	"github.com/snapp-incubator/nats-blackbox-exporter/internal/natsclient"
 	"github.com/tidwall/pretty"
 )
 
@@ -23,8 +23,8 @@ const (
 type (
 	// Config holds all configurations.
 	Config struct {
-		Logger logger.Config `json:"logger,omitempty" koanf:"logger"`
-		NATS   client.Config `json:"nats,omitempty" koanf:"nats"`
+		Logger logger.Config     `json:"logger,omitempty" koanf:"logger"`
+		NATS   natsclient.Config `json:"nats,omitempty" koanf:"nats"`
 	}
 )
 

internal/config/default.go

@@ -3,8 +3,8 @@ package config
 import (
 	"time"
 
-	"github.com/snapp-incubator/nats-blackbox-exporter/internal/client"
 	"github.com/snapp-incubator/nats-blackbox-exporter/internal/logger"
+	"github.com/snapp-incubator/nats-blackbox-exporter/internal/natsclient"
 )
 
 // Default return default configuration.
@@ -14,7 +14,7 @@ func Default() Config {
 		Logger: logger.Config{
 			Level: "debug",
 		},
-		NATS: client.Config{
+		NATS: natsclient.Config{
 			URL:             "localhost:4222",
 			PublishInterval: 2 * time.Second,
 			RequestTimeout:  50 * time.Millisecond,

internal/client/client.go → internal/natsclient/client.go

@@ -1,4 +1,4 @@
-package client
+package natsclient
 
 import (
 	"time"
@@ -7,7 +7,7 @@ import (
 	"go.uber.org/zap"
 )
 
-type Client struct {
+type NatsClient struct {
 	Conn   *nats.Conn
 	Logger *zap.Logger
 	Config Config
@@ -34,20 +34,20 @@ func Connect(logger *zap.Logger, cfg Config) *nats.Conn {
 	return nc
 }
 
-func New(nc *nats.Conn, logger *zap.Logger, cfg Config) *Client {
-	return &Client{
+func New(nc *nats.Conn, logger *zap.Logger, cfg Config) *NatsClient {
+	return &NatsClient{
 		Conn:   nc,
 		Logger: logger,
 		Config: cfg,
 	}
 }
 
-func (c *Client) StartMessaging() {
+func (c *NatsClient) StartMessaging() {
 	go c.Subscribe("")
 	go c.Publish("")
 }
 
-func (c *Client) Publish(subject string) {
+func (c *NatsClient) Publish(subject string) {
 	if subject == "" {
 		subject = c.Config.DefaultSubject
 	}
@@ -69,7 +69,7 @@ func (c *Client) Publish(subject string) {
 	}
 }
 
-func (c *Client) Subscribe(subject string) {
+func (c *NatsClient) Subscribe(subject string) {
 	if subject == "" {
 		subject = c.Config.DefaultSubject
 	}

internal/client/config.go → internal/natsclient/config.go

@@ -1,4 +1,4 @@
-package client
+package natsclient
 
 import "time"