Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for specifying configuration file path and include cluster name in metric labels #8

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

kianaza
Copy link
Collaborator

@kianaza kianaza commented Jul 5, 2024

This merge request introduces functionality to enhance our application in two key ways:

  1. Configuration File Path Flag:
    Added a -settings flag to allow users to specify the path to the configuration file (config.yaml).

  2. Cluster Name in Metric Labels:
    Included the cluster name as part of the metric labels.

@kianaza kianaza requested a review from sinamna July 5, 2024 23:01
@kianaza kianaza self-assigned this Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (276bb3a) to head (cf90ea4).

Files Patch % Lines
internal/natsclient/jetstream.go 0.00% 14 Missing ⚠️
internal/natsclient/metric.go 0.00% 7 Missing ⚠️
internal/cmd/root.go 0.00% 3 Missing ⚠️
internal/config/config.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main      #8   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          9       9           
  Lines        279     287    +8     
=====================================
- Misses       279     287    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/cmd/root.go Outdated Show resolved Hide resolved
@kianaza kianaza merged commit f9b7189 into main Jul 7, 2024
10 checks passed
@1995parham 1995parham deleted the feat/settingspath branch July 28, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants