-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter proposals by plugins
and strategies
#705
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
changed the title
feat: allow filtering proposals by plugin and strategies
feat: filter proposals by plugins and strategies
Oct 10, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
wa0x6e
changed the title
feat: filter proposals by plugins and strategies
feat: filter proposals by Oct 19, 2023
plugins
and strategies
ChaituVR
reviewed
Oct 25, 2023
ChaituVR
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to #704 (comment)
The following query query Proposals {
proposals(first: 10, where: {strategies_in: ["poap"]}) {
strategies {
name
}
}
} Does return proposals that partial match: {
"data": {
"proposals": [
{
"strategies": [
{
"name": "poap"
},
{
"name": "whitelist"
}
]
},
{
"strategies": [
{
"name": "poap"
},
{
"name": "whitelist"
}
]
},
{
"strategies": [
{
"name": "poap"
},
{
"name": "ticket"
}
]
},
{
"strategies": [
{
"name": "erc20-balance-of"
},
{
"name": "whitelist"
},
{
"name": "poap"
}
]
},
{
"strategies": [
{
"name": "whitelist"
},
{
"name": "erc20-balance-of"
},
{
"name": "poap"
}
]
},
{
"strategies": [
{
"name": "whitelist"
},
{
"name": "erc20-balance-of"
},
{
"name": "poap"
}
]
},
{
"strategies": [
{
"name": "poap"
},
{
"name": "whitelist"
}
]
},
{
"strategies": [
{
"name": "poap"
},
{
"name": "whitelist"
}
]
},
{
"strategies": [
{
"name": "poap"
}
]
},
{
"strategies": [
{
"name": "poap"
}
]
}
]
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a more robust proposal filtering by strategy and plugin name.
New filter
The current existing
plugins_contains
andstrategies_contains
are just basic string search, and will return false result.The new introduced
strategies_in
andplugins_in
filter will searc the JSON field by key name and value, and will only return exact matches, allowing queries such as:For better performance, adding an index to the JSON objects is recommended:
Fixing existing filter
The existing
validation
filter is using basic string search. It has been updated for a more robust search by JSON value.Proposed index: