ci debug

.github/workflows/continuous-integration.yml

@@ -31,11 +31,16 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v3"
+        uses: "actions/checkout@v4"
         with:
           fetch-depth: 2
-      - name: "Install requirements"
-        run: sudo apt-get update && sudo apt-get install --no-install-recommends redis-server ruby-foreman
+      - name: "Install redis server"
+        uses: shogo82148/actions-setup-redis@v1
+        with:
+          redis-version: "7.x"
+          auto-start: 'false'
+      - name: "Install cli for Procfile"
+        run: sudo apt-get update && sudo apt-get install --no-install-recommends ruby-foreman
       - name: "Start background services"
         run: sudo systemctl stop redis-server && foreman start &
       - name: "Install PHP"
@@ -47,7 +52,7 @@ jobs:
           tools: "flex"
 
       - name: "Install dependencies with Composer"
-        uses: "ramsey/composer-install@v2"
+        uses: "ramsey/composer-install@v3"
         with:
           dependency-versions: "${{ matrix.dependency-versions }}"
 

Procfile

@@ -1,6 +1,6 @@
-redis: sh -c 'cp .github/workflows/redis-configs/redis.conf /tmp/ && redis-server /tmp/redis.conf --port 6379'
+redis: sh -c 'cp .github/workflows/redis-configs/redis.conf /tmp/ && redis-server /tmp/redis.conf --port 6379 > /tmp/redis-log'
 redis-acl: sh -c 'cp .github/workflows/redis-configs/redis-acl.conf /tmp/ && redis-server /tmp/redis-acl.conf --port 7099'
-redis-sentinel: sh -c 'cp .github/workflows/redis-configs/redis-sentinel.conf /tmp/ && redis-server /tmp/redis-sentinel.conf --sentinel'
+redis-sentinel: sh -c 'cp .github/workflows/redis-configs/redis-sentinel.conf /tmp/ && redis-server /tmp/redis-sentinel.conf --sentinel >/tmp/sentinel-log'
 redis-node1: sh -c 'cp -R .github/workflows/redis-configs/redis-node1 /tmp/ && cd /tmp/redis-node1 && redis-server redis.conf --port 7079'
 redis-node2: sh -c 'cp -R .github/workflows/redis-configs/redis-node2 /tmp/ && cd /tmp/redis-node2 && redis-server redis.conf --port 7080'
 redis-node3: sh -c 'cp -R .github/workflows/redis-configs/redis-node3 /tmp/ && cd /tmp/redis-node3 && redis-server redis.conf --port 7081'

src/Factory/PhpredisClientFactory.php

@@ -146,6 +146,8 @@ private function createClientFromSentinel(string $class, array $dsns, string $al
 
                 $address = $sentinel->getMasterAddrByName($masterName);
             } catch (RedisException | RelayException $e) {
+                var_dump(file_get_contents('/tmp/redis-log'));
+                var_dump(file_get_contents('/tmp/sentinel-log'));
                 continue;
             }
 

tests/Factory/PhpredisClientFactoryTest.php

@@ -118,6 +118,10 @@ public function testCreateSentinelConfig(
         ?string $sentinelUser,
         ?string $sentinelPassword
     ): void {
+        if (!@fsockopen('127.0.0.1', 26379)) {
+            $this->markTestSkipped(sprintf('The %s requires a redis sentinel instance', self::class));
+        }
+
         $this->logger->method('debug')->with(...$this->withConsecutive(
             [$this->stringContains('Executing command "CONNECT 127.0.0.1 6379 5 <null>')],
             ['Executing command "AUTH sncredis"'],
@@ -129,7 +133,6 @@ public function testCreateSentinelConfig(
         $client = $factory->create(
             $sentinelClass,
             [
-                'redis://undefined@localhost:55555', // unreachable instance
                 'redis://sncredis@localhost:26379',
             ],
             [