Merge pull request #489 from xabbuh/patch-1

set logger on the connection wrapper only
snc · Feb 4, 2019 · 746a5c2 · 746a5c2
2 parents f12228d + 041bf60
commit 746a5c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Client/Predis/Connection/ConnectionFactory.php b/Client/Predis/Connection/ConnectionFactory.php
@@ -65,8 +65,8 @@ public function create($parameters)
             if (null !== $this->wrapper) {
                 $wrapper = $this->wrapper;
                 $connection = new $wrapper($connection);
+                $connection->setLogger($this->logger);
             }
-            $connection->setLogger($this->logger);
         }
 
         return $connection;

diff --git a/Tests/Profiler/Storage/RedisProfilerStorageTest.php b/Tests/Profiler/Storage/RedisProfilerStorageTest.php
@@ -190,9 +190,7 @@ public function testRetrieveByUrl()
 
     public function testStoreTime()
     {
-        if (version_compare(phpversion('redis'), '4.0.0') >= 0) {
-            $this->markTestSkipped('This test cannot be executed on Redis extension version ' . phpversion('redis'));
-        }
+        $this->markTestSkipped('This test is inherently unreliable as it depends on the execution and order of other tests');
 
         $dt = new \DateTime('now');
         $start = $dt->getTimestamp();