Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namejess patch 1 issues#215 #250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Namejess
Copy link

Description

Hi maintainers !

I took the liberty of replying to issue #215 regarding some screenshots in the README.

This PR adds a folder in "others" with .png format images inside. Everything should be fine, unless I missed something or made a mistake (I'm a beginner, please be indulgent :p).

Jessy DROUIN and others added 3 commits May 12, 2023 14:42
@qurious-pixel
Copy link

This is a good addition.

Could you use .github/screenshots since other is used for code?

@FitzRoyX
Copy link
Contributor

Rather than make the readme even longer, why not just google screenshots or use youtube? Or just spend the 5 minutes to build it.

@Namejess
Copy link
Author

@qurious-pixel I'll do that soon

@FitzRoyX I suppose it is a visual features some people like

@Namejess
Copy link
Author

This is a good addition.

Could you use .github/screenshots since other is used for code?

I commited a new version with your request, can you see it?

@gerudoga
Copy link

The problem with this is that it makes the repo needlessly large. Then, everyone who tries to contribute has to download screenshots they don't need and there are still places in the world with bad internet connection...

It would be better to have a section with screenshots in the wiki (https://github.com/snesrev/zelda3/wiki) and, maybe, link from the readme to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants