Skip to content

Commit

Permalink
Make notebook publicly available (#1157)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-turbaszek authored Jun 4, 2024
1 parent 9dab2a3 commit ba393cb
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

## New additions
* Added `snow app bundle` command that prepares a local folder in the project directory with artifacts to be uploaded to a stage as part of creating a Snowflake Native App.
* Added `snow notebook` commands:
* `snow notebook execute` enabling head-less execution of a notebook.
* `snow notebook create` proving an option to create a Snowflake Notebook from a file on stage.

## Fixes and improvements

Expand Down
1 change: 0 additions & 1 deletion src/snowflake/cli/api/feature_flags.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,3 @@ class FeatureFlag(FeatureFlagMixin):
ENABLE_STREAMLIT_EMBEDDED_STAGE = BooleanFlag(
"ENABLE_STREAMLIT_EMBEDDED_STAGE", False
)
ENABLE_NOTEBOOKS = BooleanFlag("ENABLE_NOTEBOOKS", False)
2 changes: 0 additions & 2 deletions src/snowflake/cli/plugins/notebook/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import typer
from snowflake.cli.api.commands.flags import identifier_argument
from snowflake.cli.api.commands.snow_typer import SnowTyper
from snowflake.cli.api.feature_flags import FeatureFlag
from snowflake.cli.api.output.types import MessageResult
from snowflake.cli.plugins.notebook.manager import NotebookManager
from snowflake.cli.plugins.notebook.types import NotebookName, NotebookStagePath
Expand All @@ -12,7 +11,6 @@
app = SnowTyper(
name="notebook",
help="Manages notebooks in Snowflake.",
hidden=FeatureFlag.ENABLE_NOTEBOOKS.is_disabled(),
)
log = logging.getLogger(__name__)

Expand Down
2 changes: 2 additions & 0 deletions tests/__snapshots__/test_help_messages.ambr
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
│ connection Manages connections to Snowflake. │
│ cortex Provides access to Snowflake Cortex. │
│ git Manages git repositories in Snowflake. │
│ notebook Manages notebooks in Snowflake. │
│ object Manages Snowflake objects like warehouses and stages │
│ snowpark Manages procedures and functions. │
│ spcs Manages Snowpark Container Services compute pools, services, │
Expand Down Expand Up @@ -7510,6 +7511,7 @@
│ connection Manages connections to Snowflake. │
│ cortex Provides access to Snowflake Cortex. │
│ git Manages git repositories in Snowflake. │
│ notebook Manages notebooks in Snowflake. │
│ object Manages Snowflake objects like warehouses and stages │
│ snowpark Manages procedures and functions. │
│ spcs Manages Snowpark Container Services compute pools, services, │
Expand Down
1 change: 1 addition & 0 deletions tests_e2e/__snapshots__/test_installation.ambr
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
│ connection Manages connections to Snowflake. │
│ cortex Provides access to Snowflake Cortex. │
│ git Manages git repositories in Snowflake. │
│ notebook Manages notebooks in Snowflake. │
│ object Manages Snowflake objects like warehouses and stages │
│ snowpark Manages procedures and functions. │
│ spcs Manages Snowpark Container Services compute pools, services, │
Expand Down

0 comments on commit ba393cb

Please sign in to comment.