fixup! fixup! Add config based feature flags

src/snowflake/cli/api/cli_global_context.py

@@ -3,7 +3,6 @@
 from typing import Dict, Optional
 
 from snowflake.cli.api.exceptions import InvalidSchemaError
-from snowflake.cli.api.feature_flags import FeatureFlag
 from snowflake.cli.api.output.formats import OutputFormat
 from snowflake.connector import SnowflakeConnection
 
@@ -250,9 +249,7 @@ def verbose(self) -> bool:
 
     @property
     def experimental(self) -> bool:
-        if self._manager.experimental:
-            return self._manager.experimental
-        return FeatureFlag.ENABLE_EXPERIMENTAL.is_enabled()
+        return self._manager.experimental
 
     @property
     def project_definition(self):

src/snowflake/cli/api/config.py

@@ -7,6 +7,7 @@
 from typing import Any, Dict, Optional, Union
 
 import tomlkit
+from click import ClickException
 from snowflake.cli.api.exceptions import (
     ConfigFileTooWidePermissionsError,
     MissingConfiguration,
@@ -161,11 +162,21 @@ def get_config_value(*path, key: str, default: Optional[Any] = Empty) -> Any:
 
 def get_config_bool_value(*path, key: str, default: Optional[Any] = Empty) -> bool:
     value = get_config_value(*path, key=key, default=default)
-    if not isinstance(value, bool):
-        raise RuntimeError(
+    # If we get bool then we can return
+    if isinstance(value, bool):
+        return value
+
+    # Now if value is not string then cast it to str. Simplifies logic for 1 and 0
+    if not isinstance(value, str):
+        value = str(value)
+
+    know_booleans_mapping = {"true": True, "false": False, "1": True, "0": False}
+
+    if value.lower() not in know_booleans_mapping:
+        raise ClickException(
             f"Expected boolean value for {'.'.join((*path, key))} option."
         )
-    return value
+    return know_booleans_mapping[value.lower()]
 
 
 def _initialise_config(config_file: Path) -> None:
@@ -176,11 +187,12 @@ def _initialise_config(config_file: Path) -> None:
     log.info("Created Snowflake configuration file at %s", CONFIG_MANAGER.file_path)
 
 
+def get_env_variable_name(*path, key: str) -> str:
+    return "SNOWFLAKE_" + "_".join(p.upper() for p in path) + f"_{key.upper()}"
+
+
 def get_env_value(*path, key: str) -> str | None:
-    env_variable_name = (
-        "SNOWFLAKE_" + "_".join(p.upper() for p in path) + f"_{key.upper()}"
-    )
-    return os.environ.get(env_variable_name)
+    return os.environ.get(get_env_variable_name(*path, key=key))
 
 
 def _find_section(*path) -> TOMLDocument:

src/snowflake/cli/api/feature_flags.py

@@ -1,18 +1,20 @@
 from enum import Enum, unique
 from typing import NamedTuple
 
-from snowflake.cli.api.config import FEATURE_FLAGS_SECTION_PATH, get_config_bool_value
+from snowflake.cli.api.config import (
+    FEATURE_FLAGS_SECTION_PATH,
+    get_config_bool_value,
+    get_env_variable_name,
+)
 
 
-class _Flag(NamedTuple):
+class BooleanFlag(NamedTuple):
     name: str
     default: bool = False
 
 
 @unique
-class FeatureFlag(Enum):
-    ENABLE_STREAMLIT_EMBED_STAGE = _Flag("ENABLE_STREAMLIT_EMBED_STAGE", False)
-
+class FeatureFlagMixin(Enum):
     def is_enabled(self) -> bool:
         return get_config_bool_value(
             *FEATURE_FLAGS_SECTION_PATH,
@@ -24,4 +26,11 @@ def is_disable(self):
         return not self.is_enabled()
 
     def env_variable(self):
-        return self.get_env_value(*FEATURE_FLAGS_SECTION_PATH, key=self.value.name)
+        return get_env_variable_name(*FEATURE_FLAGS_SECTION_PATH, key=self.value.name)
+
+
+@unique
+class FeatureFlag(FeatureFlagMixin):
+    ENABLE_STREAMLIT_EMBEDDED_STAGE = BooleanFlag(
+        "ENABLE_STREAMLIT_EMBEDDED_STAGE", False
+    )

src/snowflake/cli/plugins/streamlit/manager.py

@@ -109,7 +109,7 @@ def deploy(
         streamlit_name = self.get_name_from_fully_qualified_name(fully_qualified_name)
         if (
             experimental_behaviour_enabled()
-            or FeatureFlag.ENABLE_STREAMLIT_EMBED_STAGE.is_enabled()
+            or FeatureFlag.ENABLE_STREAMLIT_EMBEDDED_STAGE.is_enabled()
         ):
             """
             1. Create streamlit object

tests/api/commands/__snapshots__/test_snow_typer.ambr

@@ -98,5 +98,37 @@
   ╰──────────────────────────────────────────────────────────────────────────────╯
 
 
+  '''
+# ---
+# name: test_enabled_command_is_not_visible
+  '''
+  Usage: snow [OPTIONS] COMMAND [ARGS]...
+  Try 'snow --help' for help.
+  ╭─ Error ──────────────────────────────────────────────────────────────────────╮
+  │ No such command 'switchable_cmd'.                                            │
+  ╰──────────────────────────────────────────────────────────────────────────────╯
+
+  '''
+# ---
+# name: test_enabled_command_is_visible
+  '''
+
+   Usage: snow switchable_cmd [OPTIONS]                                           
+
+  ╭─ Options ────────────────────────────────────────────────────────────────────╮
+  │ --help  -h        Show this message and exit.                                │
+  ╰──────────────────────────────────────────────────────────────────────────────╯
+  ╭─ Global configuration ───────────────────────────────────────────────────────╮
+  │ --format           [TABLE|JSON]  Specifies the output format.                │
+  │                                  [default: TABLE]                            │
+  │ --verbose  -v                    Displays log entries for log levels `info`  │
+  │                                  and higher.                                 │
+  │ --debug                          Displays log entries for log levels `debug` │
+  │                                  and higher; debug logs contains additional  │
+  │                                  information.                                │
+  │ --silent                         Turns off intermediate output to console.   │
+  ╰──────────────────────────────────────────────────────────────────────────────╯
+
+
   '''
 # ---

tests/api/commands/test_snow_typer.py

@@ -39,6 +39,9 @@ def exception_handler(err):
     return _CustomTyper
 
 
+_ENABLED_FLAG = False
+
+
 def app_factory(typer_cls):
     app = typer_cls(name="snow")
 
@@ -62,6 +65,10 @@ def cmd_with_global_options(name: str = typer.Argument()):
     def cmd_with_connection_options(name: str = typer.Argument()):
         return MessageResult(f"hello {name}")
 
+    @app.command("switchable_cmd", is_enabled=lambda: _ENABLED_FLAG)
+    def cmd_witch_enabled_switch():
+        return MessageResult("Enabled")
+
     return app
 
 
@@ -147,6 +154,22 @@ def test_command_with_connection_options(cli, snapshot):
     assert result.output == snapshot
 
 
+def test_enabled_command_is_visible(cli, snapshot):
+    global _ENABLED_FLAG
+    _ENABLED_FLAG = True
+    result = cli(app_factory(SnowTyper))(["switchable_cmd", "--help"])
+    assert result.exit_code == 0
+    assert result.output == snapshot
+
+
+def test_enabled_command_is_not_visible(cli, snapshot):
+    global _ENABLED_FLAG
+    _ENABLED_FLAG = False
+    result = cli(app_factory(SnowTyper))(["switchable_cmd", "--help"])
+    assert result.exit_code == 2
+    assert result.output == snapshot
+
+
 @mock.patch("snowflake.cli.app.telemetry.log_command_usage")
 def test_snow_typer_pre_execute_sends_telemetry(mock_log_command_usage, cli):
     result = cli(app_factory(SnowTyper))(["simple_cmd", "Norma"])

tests/api/test_feature_flags.py

@@ -0,0 +1,65 @@
+from unittest import mock
+
+import pytest
+from click import ClickException
+from snowflake.cli.api.feature_flags import BooleanFlag, FeatureFlagMixin
+
+
+class _TestFlags(FeatureFlagMixin):
+    # Intentional inconsistency between constant and the enum name to make sure there's no strict relation
+    ENABLED_BY_DEFAULT = BooleanFlag("ENABLED_DEFAULT", True)
+    DISABLED_BY_DEFAULT = BooleanFlag("DISABLED_DEFAULT", False)
+    NON_BOOLEAN = BooleanFlag("NON_BOOLEAN", "xys")  # type: ignore
+
+
+def test_flag_value_has_to_be_boolean():
+    with pytest.raises(ClickException):
+        _TestFlags.NON_BOOLEAN.is_enabled()
+
+
+def test_flag_is_enabled():
+    assert _TestFlags.ENABLED_BY_DEFAULT.is_enabled() is True
+    assert _TestFlags.ENABLED_BY_DEFAULT.is_disable() is False
+
+
+def test_flag_is_disabled():
+    assert _TestFlags.DISABLED_BY_DEFAULT.is_enabled() is False
+    assert _TestFlags.DISABLED_BY_DEFAULT.is_disable() is True
+
+
+def test_flag_env_variable_value():
+    assert (
+        _TestFlags.ENABLED_BY_DEFAULT.env_variable()
+        == "SNOWFLAKE_CLI_FEATURES_ENABLED_DEFAULT"
+    )
+    assert (
+        _TestFlags.DISABLED_BY_DEFAULT.env_variable()
+        == "SNOWFLAKE_CLI_FEATURES_DISABLED_DEFAULT"
+    )
+
+
+@mock.patch("snowflake.cli.api.config.get_config_value")
+@pytest.mark.parametrize("value_from_config", [True, False])
+def test_flag_from_config_file(mock_get_config_value, value_from_config):
+    mock_get_config_value.return_value = value_from_config
+
+    assert _TestFlags.DISABLED_BY_DEFAULT.is_enabled() is value_from_config
+    mock_get_config_value.assert_called_once_with(
+        "cli", "features", key="disabled_default", default=False
+    )
+
+
+@pytest.mark.parametrize("value_from_env", ["1", "true", "True", "TRUE", "TruE"])
+def test_flag_is_enabled_from_env_var(value_from_env):
+    with mock.patch.dict(
+        "os.environ", {"SNOWFLAKE_CLI_FEATURES_DISABLED_DEFAULT": value_from_env}
+    ):
+        assert _TestFlags.DISABLED_BY_DEFAULT.is_enabled() is True
+
+
+@pytest.mark.parametrize("value_from_env", ["0", "false", "False", "FALSE", "FaLse"])
+def test_flag_is_disabled_from_env_var(value_from_env):
+    with mock.patch.dict(
+        "os.environ", {"SNOWFLAKE_CLI_FEATURES_ENABLED_DEFAULT": value_from_env}
+    ):
+        assert _TestFlags.ENABLED_BY_DEFAULT.is_enabled() is False

tests/plugin/__snapshots__/test_override_by_external_plugins.ambr

@@ -0,0 +1,19 @@
+# serializer version: 1
+# name: test_corrupted_config_raises_human_friendly_error[[corrupted0]
+  '''
+  ╭─ Error ──────────────────────────────────────────────────────────────────────╮
+  │ Configuration file seems to be corrupted. Unexpected end of file at line 1   │
+  │ col 10                                                                       │
+  ╰──────────────────────────────────────────────────────────────────────────────╯
+
+  '''
+# ---
+# name: test_corrupted_config_raises_human_friendly_error[[corrupted1]
+  '''
+  ╭─ Error ──────────────────────────────────────────────────────────────────────╮
+  │ Configuration file seems to be corrupted. Unexpected end of file at line 1   │
+  │ col 10                                                                       │
+  ╰──────────────────────────────────────────────────────────────────────────────╯
+
+  '''
+# ---