Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "execute immediate" for python files #1018

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

@sfc-gh-turbaszek sfc-gh-turbaszek force-pushed the python-execute branch 2 times, most recently from 4db55b4 to 27bbcaa Compare May 9, 2024 06:26
@sfc-gh-turbaszek sfc-gh-turbaszek added the enhancement New feature or request label May 23, 2024
@sfc-gh-turbaszek sfc-gh-turbaszek force-pushed the python-execute branch 2 times, most recently from 54d1369 to db0db7d Compare June 11, 2024 13:04
@@ -20,6 +20,7 @@

TEMPLATES_PATH = Path(__file__).parent.parent / "templates"
DEPLOYMENT_STAGE = "deployments"
PYTHON_3_12 = (3, 12)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review July 9, 2024 09:11
@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners July 9, 2024 09:11
RELEASE-NOTES.md Outdated Show resolved Hide resolved
RELEASE-NOTES.md Outdated Show resolved Hide resolved
sfc-gh-astus
sfc-gh-astus previously approved these changes Jul 10, 2024
self._snowpark_session = Session.builder.configs(
{"connection": self._conn}
).create()
return self._snowpark_session
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you open second connection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same connection, but wrapped around Snowpark util

@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 89660c9 into main Jul 12, 2024
16 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the python-execute branch July 12, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants