Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NADE] Add feature check to allow codegen #1048

Merged

Conversation

sfc-gh-bgoel
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code - N/A
  • I've added or updated integration tests to verify correctness of my new code - N/A
  • I've confirmed that my changes are working by executing CLI's commands manually - N/A
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes - N/A
  • I've described my changes in the section below.

Changes description

Add a feature check in build_bundle to allow for codegen.

@sfc-gh-bgoel sfc-gh-bgoel marked this pull request as ready for review May 9, 2024 02:22
@sfc-gh-bgoel sfc-gh-bgoel requested a review from a team as a code owner May 9, 2024 02:22
@@ -47,6 +50,7 @@
MissingPackageScriptError,
UnexpectedOwnerError,
)
from snowflake.cli.plugins.nativeapp.feature_flags import FeatureFlag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not the gist of the change but should we consider renaming FeatureFlag to NativeAppFeatureFlags? In this way we may avoid any ambiguity with existing snowflake.cli.api.feature_flags.FeatureFlag. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it common already to have the same files in multiple plugin directories if they define the same concepts? I'm thinking commands and manager, for example. Native apps code shouldn't rely on feature flags outside of its own IMHO, so at least now there shouldn't be ambiguity.

@sfc-gh-bdufour
Copy link
Contributor

Bhumika, not following the target branch here. Shouldn't we target feature-snowpark-annotations instead? Let's not create complex branching/merging structures, it will be a pain to deal with later. This should stack on top of your other work, on the common feature branch.

Copy link
Contributor Author

@sfc-gh-bgoel sfc-gh-bgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-bdufour, yes you are right that the target branch needs to be the feature branch I created. But this should either be 1. Automatically changed by github once I merge bgoel-collect-external-functions or 2. I retarget it to feature-snowflake-snowpark.

The current way of targeting was to isolate changes from just this enablement.

Base automatically changed from bgoel-collect-external-functions to feature-snowpark-annotations May 9, 2024 13:49
@sfc-gh-bgoel sfc-gh-bgoel requested a review from a team as a code owner May 9, 2024 13:49
@sfc-gh-bgoel sfc-gh-bgoel force-pushed the bgoel-add-feature-enablement branch from 7e4ebd7 to be3b982 Compare May 9, 2024 14:06
@sfc-gh-bgoel sfc-gh-bgoel merged commit 63884b4 into feature-snowpark-annotations May 9, 2024
23 checks passed
@sfc-gh-bgoel sfc-gh-bgoel deleted the bgoel-add-feature-enablement branch May 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants