-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NADE] Add feature check to allow codegen #1048
[NADE] Add feature check to allow codegen #1048
Conversation
@@ -47,6 +50,7 @@ | |||
MissingPackageScriptError, | |||
UnexpectedOwnerError, | |||
) | |||
from snowflake.cli.plugins.nativeapp.feature_flags import FeatureFlag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not the gist of the change but should we consider renaming FeatureFlag
to NativeAppFeatureFlags
? In this way we may avoid any ambiguity with existing snowflake.cli.api.feature_flags.FeatureFlag.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it common already to have the same files in multiple plugin directories if they define the same concepts? I'm thinking commands and manager, for example. Native apps code shouldn't rely on feature flags outside of its own IMHO, so at least now there shouldn't be ambiguity.
Bhumika, not following the target branch here. Shouldn't we target feature-snowpark-annotations instead? Let's not create complex branching/merging structures, it will be a pain to deal with later. This should stack on top of your other work, on the common feature branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-bdufour, yes you are right that the target branch needs to be the feature branch I created. But this should either be 1. Automatically changed by github once I merge bgoel-collect-external-functions or 2. I retarget it to feature-snowflake-snowpark.
The current way of targeting was to isolate changes from just this enablement.
7e4ebd7
to
be3b982
Compare
Pre-review checklist
Changes description
Add a feature check in
build_bundle
to allow for codegen.