Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1348392 update replace checks #1049

Merged
merged 10 commits into from
May 9, 2024
Merged

Snow 1348392 update replace checks #1049

merged 10 commits into from
May 9, 2024

Conversation

sfc-gh-jsikorski
Copy link
Contributor

@sfc-gh-jsikorski sfc-gh-jsikorski commented May 9, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixes the missing check for changes in external access integrations when deploying snowpark objects with --replace.

Also, this solves a little bug with building and udf sproc identifier, when argument is set to empty string.

@sfc-gh-jsikorski sfc-gh-jsikorski marked this pull request as ready for review May 9, 2024 12:47
@sfc-gh-jsikorski sfc-gh-jsikorski requested a review from a team as a code owner May 9, 2024 12:47
sfc-gh-mraba
sfc-gh-mraba previously approved these changes May 9, 2024
View reviewed changes
@sfc-gh-jsikorski sfc-gh-jsikorski enabled auto-merge (squash) May 9, 2024 15:07
@sfc-gh-jsikorski sfc-gh-jsikorski merged commit 4c17859 into main May 9, 2024
23 checks passed
@sfc-gh-jsikorski sfc-gh-jsikorski deleted the SNOW-1348392-update-replace-checks branch May 9, 2024 16:06
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-jsikorski
Snow 1348392 update replace checks (#1049)
9de24da 
* Init

* Init

* Fix for tests

* Fix for check

* Added info to release notes

* Removed unnecesary arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mraba sfc-gh-mraba sfc-gh-mraba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jsikorski @sfc-gh-mraba