Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command error to telemetry #1266

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Add command error to telemetry #1266

merged 6 commits into from
Jul 17, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Jun 27, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • N/A I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • N/A I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

Add event to send information when an error is encountered during the execution of a command.

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the jvasquezrojas-add-errors-to-telemetry branch from de89d8b to a541990 Compare July 1, 2024 18:14
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review July 4, 2024 19:54
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner July 4, 2024 19:54
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the jvasquezrojas-add-errors-to-telemetry branch from 82efb0c to b13ff93 Compare July 5, 2024 10:51
sfc-gh-bdufour
sfc-gh-bdufour reviewed Jul 10, 2024
View reviewed changes
src/snowflake/cli/app/telemetry.py Outdated Show resolved Hide resolved
src/snowflake/cli/app/execution_metadata.py Outdated Show resolved Hide resolved
src/snowflake/cli/app/telemetry.py Show resolved Hide resolved
@sfc-gh-jvasquezrojas
Add error to telemetry
1156513 
Remove debug print

Remove debug print

Update test to cover error type

Add UUID to telemetry data based on the command execution flow

Update tests

Add flag to indicate if error is expected or not

Add result event and start, end time for command execution

Add duration time

Rename function name
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the jvasquezrojas-add-errors-to-telemetry branch from dbb8f77 to 1156513 Compare July 11, 2024 13:47
sfc-gh-bdufour
sfc-gh-bdufour previously approved these changes Jul 11, 2024
View reviewed changes
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas enabled auto-merge (squash) July 15, 2024 19:33
sfc-gh-bdufour
sfc-gh-bdufour previously approved these changes Jul 16, 2024
View reviewed changes
@sfc-gh-bdufour
Copy link
Contributor

LGTM for NADE

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas enabled auto-merge (squash) July 17, 2024 14:22
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit 7bb9b28 into main Jul 17, 2024
18 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the jvasquezrojas-add-errors-to-telemetry branch July 17, 2024 15:01
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-jvasquezrojas
Add command error to telemetry (#1266)
04d2b23 
 Add error events to telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek left review comments

@sfc-gh-mraba sfc-gh-mraba sfc-gh-mraba approved these changes

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-jvasquezrojas @sfc-gh-bdufour @sfc-gh-turbaszek @sfc-gh-mraba