Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git execute with upper letter in directory #1494

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Fix git execute with upper letter in directory #1494

merged 5 commits into from
Sep 4, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Aug 26, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • N/A I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...
Fix git execute was failing when the directory contained a character in upper case.
Example:

(snowflake-cli-labs) (base) jvasquezrojas@V9P2792XJ5 snowflake-cli % snow git list-files "@jvasquez_repository/branches/dev/CICD/DB1/example.sql" -c integration                                            
+------------------------------------------------------------------------------------------------------------------------------------------------+
| name                                                  | size | md5  | sha1                                     | last_modified                 |
|-------------------------------------------------------+------+------+------------------------------------------+-------------------------------|
| jvasquez_repository/branches/dev/CICD/DB1/example.sql | 24   | None | 5114d9d042eaf0f2102539304a8d1903fc73648f | Thu, 22 Aug 2024 04:18:41 GMT |
+------------------------------------------------------------------------------------------------------------------------------------------------+

(snowflake-cli-labs) (base) jvasquezrojas@V9P2792XJ5 snowflake-cli % snow git execute "@jvasquez_repository/branches/dev/CICD/DB1/example.sql" -c integration
╭─ Error ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ No files matched pattern '@jvasquez_repository/branches/dev/CICD/DB1/example.sql'                                                                │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Ticket:
https://snowflakecomputing.atlassian.net/browse/SNOW-1636439

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested review from a team as code owners August 26, 2024 16:53
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the git_execute_with_upper_letter_in_directory branch 5 times, most recently from 625bcff to 7c6a495 Compare August 26, 2024 17:18
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas mentioned this pull request Aug 26, 2024
Merged
5 tasks
@sfc-gh-turbaszek sfc-gh-turbaszek linked an issue Aug 27, 2024 that may be closed by this pull request
SNOW-1636439: "No files matched pattern" error when directory contains names in upper case. #1468
Closed
sfc-gh-melnacouzi
sfc-gh-melnacouzi reviewed Aug 29, 2024
View reviewed changes
RELEASE-NOTES.md Outdated Show resolved Hide resolved
src/snowflake/cli/_plugins/git/manager.py Outdated Show resolved Hide resolved
src/snowflake/cli/_plugins/stage/manager.py Outdated Show resolved Hide resolved
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the git_execute_with_upper_letter_in_directory branch 2 times, most recently from f018b4e to b54ffaf Compare August 29, 2024 20:19
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) August 30, 2024 09:07
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the git_execute_with_upper_letter_in_directory branch from a828575 to 8fad0bb Compare August 30, 2024 16:33
sfc-gh-astus
sfc-gh-astus previously approved these changes Sep 2, 2024
View reviewed changes
src/snowflake/cli/_plugins/stage/manager.py Outdated Show resolved Hide resolved
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the git_execute_with_upper_letter_in_directory branch from ab95923 to 741517e Compare September 4, 2024 06:28
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 89551de into main Sep 4, 2024
18 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the git_execute_with_upper_letter_in_directory branch September 4, 2024 07:46
sfc-gh-pczajka pushed a commit that referenced this pull request Sep 10, 2024
@sfc-gh-jvasquezrojas @sfc-gh-pczajka
Fix git execute with upper letter in directory (#1494)
eecb877
sfc-gh-pczajka added a commit that referenced this pull request Sep 10, 2024
@sfc-gh-pczajka @sfc-gh-jvasquezrojas
@sfc-gh-astus @sfc-gh-turbaszek
Release v2.8.1 - version update and cherry picks (#1550)
b1231dc 
* Fix git execute with upper letter in directory (#1494)

* Stage execute fix (#1525)

Added more tests for stage execute

* Use IDENTIFIER for string literals (#1409)

* Fix git setup with FQN repo names (#1530)

* Snow 1644844 git setup api integration naming fix (#1532)

* git setup: proposed object name should be unique

* add unit tests

* self review

* fix tests

* existing secret can be FQN

* update release notes

* Fetch existing integration in single query

* fix unit tests

* fix release notes

* fix diag_log_path default value (#1533)

* fix diag_log_path default value

* fix tests

* Add unit test checking whether default value got overridden

* Snow 1650685 fix snowpark package (#1541)

* bump version and release notes

* update snapshots

---------

Co-authored-by: Jorge Vasquez Rojas <[email protected]>
Co-authored-by: Adam Stus <[email protected]>
Co-authored-by: Tomasz Urbaszek <[email protected]>
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-jvasquezrojas
Fix git execute with upper letter in directory (#1494)
a3fc58f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi left review comments

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski left review comments

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1636439: "No files matched pattern" error when directory contains names in upper case.
6 participants
@sfc-gh-jvasquezrojas @sfc-gh-turbaszek @sfc-gh-astus @sfc-gh-jsikorski @sfc-gh-melnacouzi @sfc-gh-pczajka