Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Add decorator to extract a single app and package from a PDFv2 #1635

Closed
wants to merge 1 commit into from
Closed

SNOW-1706990 Add decorator to extract a single app and package from a PDFv2 #1635

wants to merge 1 commit into from

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch from cf35d95 to 0178f9d Compare September 27, 2024 22:11
@sfc-gh-fcampbell sfc-gh-fcampbell changed the base branch from main to frank-find-nested-manifest September 27, 2024 22:11
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-find-nested-manifest branch from 85f976d to 4054e22 Compare September 30, 2024 13:09
Base automatically changed from frank-find-nested-manifest to main September 30, 2024 13:31
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch 2 times, most recently from 5654c29 to 3b79065 Compare October 1, 2024 19:57
@sfc-gh-fcampbell sfc-gh-fcampbell mentioned this pull request Oct 2, 2024
Merged
8 tasks
@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Add decorator to extract a single app and package from a PDFv2 SNOW-1706990 Add decorator to extract a single app and package from a PDFv2 Oct 2, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch from 701b845 to fd49066 Compare October 2, 2024 15:59
@sfc-gh-fcampbell sfc-gh-fcampbell mentioned this pull request Oct 3, 2024
Merged
8 tasks
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch 2 times, most recently from 21121f9 to b70cff5 Compare October 3, 2024 16:54
sfc-gh-fcampbell added a commit that referenced this pull request Oct 3, 2024
@sfc-gh-fcampbell
SNOW-1706990 Extract fields in compat module (#1663)
8ab0a0f 
No material changes, just extracting the entity finding logic into `_find_app_and_package_entities` and the Typer options into `APP_AND_PACKAGE_OPTIONS` slim the diff in #1635.
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch 3 times, most recently from bf57fbb to 2debee9 Compare October 3, 2024 18:27
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-peel-back-manager-1 branch from 2debee9 to 48d3033 Compare October 3, 2024 18:27
@sfc-gh-fcampbell
Copy link
Contributor Author

Reworked in #1667, will convert the other snow app commands in separate PRs

@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-peel-back-manager-1 branch October 4, 2024 17:06
@sfc-gh-fcampbell sfc-gh-fcampbell restored the frank-peel-back-manager-1 branch October 8, 2024 14:25
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-peel-back-manager-1 branch October 8, 2024 14:25
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-fcampbell
SNOW-1706990 Extract fields in compat module (#1663)
42fb8bc 
No material changes, just extracting the entity finding logic into `_find_app_and_package_entities` and the Typer options into `APP_AND_PACKAGE_OPTIONS` slim the diff in #1635.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-fcampbell