Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1846319: Add Feature Flag for log streaming #1925

Merged
merged 6 commits into from
Dec 12, 2024
Merged

SNOW-1846319: Add Feature Flag for log streaming #1925

merged 6 commits into from
Dec 12, 2024

Conversation

sfc-gh-ashen
Copy link
Contributor

@sfc-gh-ashen sfc-gh-ashen commented Dec 5, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Feature Flag Addition: Introduced a new feature flag, ENABLE_SPCS_LOG_STREAMING, to control the rollout of the log streaming feature.
  • New Exception: Introduced FeatureNotEnabledError to handle cases where a feature flag is disabled. When attempting to use log streaming while the feature flag is turned off, users will see the following error message:
    "Streaming logs from spcs containers is disabled. Set the following field in your configuration to enable it: 'ENABLE_SPCS_LOG_STREAMING'."

@sfc-gh-ashen sfc-gh-ashen requested a review from a team as a code owner December 5, 2024 22:46
@sfc-gh-ashen sfc-gh-ashen marked this pull request as draft December 5, 2024 22:57
@sfc-gh-ashen sfc-gh-ashen self-assigned this Dec 5, 2024
@sfc-gh-ashen sfc-gh-ashen marked this pull request as ready for review December 6, 2024 22:58
sfc-gh-tkommineni
sfc-gh-tkommineni previously approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tkommineni sfc-gh-tkommineni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-ashen sfc-gh-ashen force-pushed the SNOW-1846319-add-feature-flag-for-spcs-snow-cli-log-streaming branch from 4735b7b to ad7402d Compare December 10, 2024 19:51
sfc-gh-astus
sfc-gh-astus previously approved these changes Dec 12, 2024
View reviewed changes
@sfc-gh-ashen sfc-gh-ashen merged commit b22b5b4 into main Dec 12, 2024
18 checks passed
@sfc-gh-ashen sfc-gh-ashen deleted the SNOW-1846319-add-feature-flag-for-spcs-snow-cli-log-streaming branch December 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka left review comments

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus left review comments

@sfc-gh-tkommineni sfc-gh-tkommineni sfc-gh-tkommineni left review comments

Assignees

@sfc-gh-ashen sfc-gh-ashen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-ashen @sfc-gh-tkommineni @sfc-gh-astus @sfc-gh-jsikorski @sfc-gh-pczajka