Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release channels add-accounts remove-accounts commands #1955

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add release channels add-accounts remove-accounts commands #1955

merged 2 commits into from
Dec 18, 2024

Conversation

sfc-gh-melnacouzi
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Add commands to add and remove accounts from release channels:
snow app release-channel add-accounts CHANNEL --target-accounts=org1.acc1,org2.acc2
and
snow app release-channel remove-accounts CHANNEL --target-accounts=org1.acc1,org2.acc2

@sfc-gh-melnacouzi sfc-gh-melnacouzi requested review from a team as code owners December 18, 2024 13:46
@sfc-gh-melnacouzi sfc-gh-melnacouzi force-pushed the melnacouzi-release-channels-add-remove-accounts branch from e441a5e to 194f23f Compare December 18, 2024 14:25
sfc-gh-gbloom
sfc-gh-gbloom reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-gbloom sfc-gh-gbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we finalize the command syntax? I would expect the channel to be specified as a parameter of the release-channel command, not the add-accounts sub-command:

snow app release-channel -c CHANNEL add-accounts --target-accounts=org1.acc1,org2.acc2

src/snowflake/cli/_plugins/nativeapp/entities/application_package.py Outdated Show resolved Hide resolved
@sfc-gh-melnacouzi
Copy link
Contributor Author

sfc-gh-melnacouzi commented Dec 18, 2024 •
edited
Loading

Did we finalize the command syntax? I would expect the channel to be specified as a parameter of the release-channel command, not the add-accounts sub-command:

snow app release-channel -c CHANNEL add-accounts --target-accounts=org1.acc1,org2.acc2

Yes this was finalized in the design.
Regarding your suggestion, I don't see any command currently using this pattern in SnowCLI.

the 2 contestants for this were:
snow app release-channel add-accounts --channel=CHANNEL --target-accounts=org1.acc1,org2.acc2
vs
snow app release-channel add-accounts --target-accounts=org1.acc1,org2.acc2 CHANNEL

I went with the second one to be consistent with release directives commands, and I also found similar pattern in snow app version. This was also decided based on feedback from the team on snow app release-directive set DIRECTIVE vs snow app release-directive set --directive=directive.

This is a bit trickier because of the composite verb "add-accounts".

@sfc-gh-melnacouzi sfc-gh-melnacouzi merged commit a44f54a into main Dec 18, 2024
20 checks passed
@sfc-gh-melnacouzi sfc-gh-melnacouzi deleted the melnacouzi-release-channels-add-remove-accounts branch December 18, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gbloom sfc-gh-gbloom sfc-gh-gbloom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-melnacouzi @sfc-gh-gbloom