Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-830291, XMLParser - initialisation with custom configuration #538

Merged
merged 3 commits into from
Jul 7, 2023
Merged

SNOW-830291, XMLParser - initialisation with custom configuration #538

merged 3 commits into from
Jul 7, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Jun 15, 2023 •
edited
Loading

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (there is no automatic linter yet)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@github-actions
Copy link

github-actions bot commented Jun 15, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Jun 15, 2023
Closed
sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Jun 19, 2023
View reviewed changes
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/core.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz mentioned this pull request Jun 22, 2023
Merged
sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Jun 22, 2023
View reviewed changes
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki self-assigned this Jun 23, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki added bug Something isn't working and removed bug Something isn't working labels Jun 23, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki removed their assignment Jun 23, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review June 23, 2023 09:28
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner June 23, 2023 09:28
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jun 26, 2023
View reviewed changes
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jun 30, 2023
View reviewed changes
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/core.js Outdated Show resolved Hide resolved
lib/global_config.js Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jul 3, 2023
View reviewed changes
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/connection/result/column.js Outdated Show resolved Hide resolved
lib/global_config.js Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 24a6369 into master Jul 7, 2023
15 of 16 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-830291 branch July 7, 2023 05:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title SNOW-830291, #506 XMLParser - initialisation with custom configuration SNOW-830291, XMLParser - initialisation with custom configuration Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-igarish @sfc-gh-dprzybysz