Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-831683: Retry and cleanup testPutGet and testArrayBindCustomerTable #546

Merged
merged 1 commit into from
Jun 28, 2023
Merged

SNOW-831683: Retry and cleanup testPutGet and testArrayBindCustomerTable #546

merged 1 commit into from
Jun 28, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

In testArrayBindCustomerTable and testPutGet:

  • retry flaky tests with mocha built-in retry mechanism
  • format files with eslint
  • don't call done in async.series explicitly - use callback instead
  • move common setup and teardown operations to before and after to ensure that for errors resources are correctly cleaned up

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner June 22, 2023 09:52
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-831683-retry-and-cleanup-test-put-get-and-customer-array-bind branch from 572c416 to 0790747 Compare June 22, 2023 10:20
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-831683-retry-and-cleanup-test-put-get-and-customer-array-bind branch from 0790747 to ded06a5 Compare June 23, 2023 06:19
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-831683-retry-and-cleanup-test-put-get-and-customer-array-bind branch 3 times, most recently from 8d92ea3 to ed42613 Compare June 27, 2023 11:15
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-831683-retry-and-cleanup-test-put-get-and-customer-array-bind branch from ed42613 to 4c5aff9 Compare June 28, 2023 05:09
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 4639c98 into master Jun 28, 2023
16 of 17 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-831683-retry-and-cleanup-test-put-get-and-customer-array-bind branch June 28, 2023 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-igarish @sfc-gh-pmotacki