Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-848733: Run CI builds in parallel #552

Merged
merged 1 commit into from
Jun 27, 2023
Merged

SNOW-848733: Run CI builds in parallel #552

merged 1 commit into from
Jun 27, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review June 26, 2023 09:29
@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner June 26, 2023 09:29
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title Snow 848733 run tests in parallel SNOW-848733: Run CI builds in parallel Jun 26, 2023
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-848733-run-tests-in-parallel branch 2 times, most recently from 5d597e9 to 76820cf Compare June 26, 2023 11:48
sfc-gh-kdama
sfc-gh-kdama approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-kdama sfc-gh-kdama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-igarish
Copy link
Collaborator

What will happen if all tests run on different OS run in parallel and they run on same account, database, schema etc.? Will it cause issues such as one OS drop the table while another really need it?

@sfc-gh-dprzybysz
Copy link
Collaborator Author

What will happen if all tests run on different OS run in parallel and they run on same account, database, schema etc.? Will it cause issues such as one OS drop the table while another really need it?

We are creating unique schema per test run based on runner id and commit sha: https://github.com/snowflakedb/snowflake-connector-nodejs/blob/master/ci/container/test_component.sh#L43

If we don't create/change anything without schema then tests do not influence each other

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-848733-run-tests-in-parallel branch from 76820cf to c4d745e Compare June 27, 2023 05:13
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit b0148c2 into master Jun 27, 2023
15 of 16 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-848733-run-tests-in-parallel branch June 27, 2023 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-kdama sfc-gh-kdama sfc-gh-kdama approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki Awaiting requested review from sfc-gh-pmotacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-igarish @sfc-gh-kdama