Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-855106: Use correct way to import a uuid library #562

Merged
merged 2 commits into from
Jul 4, 2023
Merged

SNOW-855106: Use correct way to import a uuid library #562

merged 2 commits into from
Jul 4, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Jul 3, 2023 •
edited
Loading

Description

After adding nyc dependency I have an effect of problem with building on github environment. I've investigate that it can be fix by change a import of uuid library in accordance with the documentation

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner July 3, 2023 10:02
@sfc-gh-igarish
Copy link
Collaborator

Please add description why it stops working as it was working in the past.

sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 72f5f09 into master Jul 4, 2023
15 of 16 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-855106 branch July 4, 2023 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-igarish @sfc-gh-dprzybysz