Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to increase code coverage #565

Merged
merged 14 commits into from
Jul 18, 2023
Merged

Add tests to increase code coverage #565

merged 14 commits into from
Jul 18, 2023

Conversation

sfc-gh-ext-simba-ll
Copy link
Contributor

@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll commented Jul 4, 2023 •
edited
Loading

Issue 114

@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll marked this pull request as ready for review July 7, 2023 17:05
@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll requested a review from a team as a code owner July 7, 2023 17:05
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-igarish
Copy link
Collaborator

@sfc-gh-dprzybysz Please review it.

sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Jul 10, 2023
View reviewed changes
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/unit/file_transfer_agent/azure_test.js Outdated Show resolved Hide resolved
test/unit/file_transfer_agent/azure_test.js Outdated Show resolved Hide resolved
test/unit/file_transfer_agent/azure_test.js Outdated Show resolved Hide resolved
test/unit/file_transfer_agent/azure_test.js Outdated Show resolved Hide resolved
test/unit/file_transfer_agent/azure_test.js Show resolved Hide resolved
sfc-gh-pmotacki
sfc-gh-pmotacki reviewed Jul 12, 2023
View reviewed changes
lib/file_transfer_agent/azure_util.js Outdated Show resolved Hide resolved
test/integration/testConnectionPoolExecute.js Outdated Show resolved Hide resolved
test/integration/testConnectionPoolExecute.js Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz mentioned this pull request Jul 18, 2023
Closed
5 tasks
@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll merged commit 7d7b09d into master Jul 18, 2023
16 of 17 checks passed
@sfc-gh-ext-simba-ll sfc-gh-ext-simba-ll deleted the codecoverage114 branch July 18, 2023 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-ext-simba-ll @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pmotacki