Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-728173: Remove new line for verifier the private key end #566

Merged
merged 1 commit into from
Jul 6, 2023
Merged

SNOW-728173: Remove new line for verifier the private key end #566

merged 1 commit into from
Jul 6, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Accept private key with new lines at the end

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner July 5, 2023 07:22
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Jul 5, 2023
Closed
sfc-gh-pfus
sfc-gh-pfus reviewed Jul 5, 2023
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-728173-do-not-fail-on-private-key-without-new-lines-at-the-end branch from dad7faf to bdea97f Compare July 5, 2023 08:15
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-728173-do-not-fail-on-private-key-without-new-lines-at-the-end branch from bdea97f to b65504f Compare July 5, 2023 08:36
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-728173-do-not-fail-on-private-key-without-new-lines-at-the-end branch from b65504f to a53805f Compare July 5, 2023 08:39
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit cf02f0b into master Jul 6, 2023
15 of 16 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-728173-do-not-fail-on-private-key-without-new-lines-at-the-end branch July 6, 2023 05:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki Awaiting requested review from sfc-gh-pmotacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dprzybysz @sfc-gh-igarish @sfc-gh-pfus @sfc-gh-ext-simba-dl