Fix/stale authenticator reference for external SSO connection caching

[supermacro]

Description

#820 Implemented sso token caching. However token caching does not work in version 1.13.1 of this lib (and possibly other versions). Every new connection fails to use the id token that is written to disk.

Issues found:

• in order for an ID token to be written to disk, clientStoreTemporaryCredential needs to be set to true in the connection config, yet it's not a field defined in index.d.ts.
• The connectionConfig (in connection.js) that the sf service has access to does not have a idToken set (even though there is one available), which seems to indicate that the sf service has a stale closure / reference to connectionConfig
  • one can prove that one is set by console.log'ing connectionConfig.idToken inside of connection.js:295

relatedly, the docs are outdated as they do not specify that connection caching is supported for the NodeJS driver

Testing the fix

Run the following script twice:

const sf = require('./supermacro-snowflake-connector-nodejs/lib/snowflake')

const conn = sf.createConnection({
  username: '<redacted>',
  account: '<redacted>',
  authenticator: 'externalbrowser',
  database: '<redacted>',
  schema: '<redacted>',
  clientStoreTemporaryCredential: true,
  credentialCacheDir: '.', // relative to current dir where the app is run
})

conn.connectAsync((err, econnected) => {
  if (err) {
    console.error('Unable to connect: ' + err.message);
    return
  }

  console.log('Connection successfully established!')
})

Expected / fixed behaviour:

• First run opens up a new browser tab to initiate external SSO flow
• Second run DOES NOT open a new browser tab and instead snowflake-sdk uses id token inside of temporary_credential.json file that was written to disk during initial authentication flow

Checklist

• Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
• Create tests which fail without the change (if possible)
• Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
• Extend the README / documentation and ensure is properly displayed (if necessary)
• Provide JIRA issue id (if possible) or GitHub issue id in commit message

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[supermacro]

I have read the CLA Document and I hereby sign the CLA

[supermacro]

recheck

[sfc-gh-dszmolka]

can you please check https://docs.snowflake.com/en/developer-guide/node-js/nodejs-driver-authenticate#authentication-token-caching ? the token cache should not work without the server side component turned on. tested it after the feature was released and worked for me (on Linux).

if you see an issue, please file an Issue.

[supermacro]

Related: #919

[supermacro]

can you please check https://docs.snowflake.com/en/developer-guide/node-js/nodejs-driver-authenticate#authentication-token-caching ? the token cache should not work without the server side component turned on. tested it after the feature was released and worked for me (on Linux).

if you see an issue, please file an Issue.

We eneabled the server side component by running

ALTER ACCOUNT SET ALLOW_ID_TOKEN = TRUE;

#921