Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Connection.getServiceName type definition #923

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add missing Connection.getServiceName type definition #923

merged 2 commits into from
Oct 1, 2024

Conversation

felipecsl
Copy link
Contributor

Description

The type definition for Connection was missing getServiceName()

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@felipecsl felipecsl requested a review from a team as a code owner September 30, 2024 23:07
@felipecsl felipecsl changed the title add missing Connection.getServiceName type definition Add missing Connection.getServiceName type definition Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@felipecsl
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit df2ace7 into snowflakedb:master Oct 1, 2024
55 of 92 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa Awaiting requested review from sfc-gh-pbulawa

@sfc-gh-dstempniak sfc-gh-dstempniak Awaiting requested review from sfc-gh-dstempniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipecsl @sfc-gh-pmotacki @sfc-gh-astachowski