Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1437294: CI/CD #4

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

SNOW-1437294: CI/CD #4

wants to merge 15 commits into from

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Sep 20, 2024 •
edited
Loading

Overview

SNOW-1437294

GCP and Azure does not support the HTAP yet, thus running only unit and standard tables tests on these environments.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new dependency or upgrading an existing one

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1437294-ci-cd branch 2 times, most recently from a628e92 to 7825490 Compare October 1, 2024 13:46
@sfc-gh-pbulawa sfc-gh-pbulawa marked this pull request as ready for review October 1, 2024 14:25
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner October 1, 2024 14:25
sfc-gh-akolodziejczyk
sfc-gh-akolodziejczyk approved these changes Oct 3, 2024
View reviewed changes
Copy link

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk approved these changes

@sfc-gh-fpawlowski sfc-gh-fpawlowski Awaiting requested review from sfc-gh-fpawlowski

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-akolodziejczyk @sfc-gh-fpawlowski