SNOW-1813772 Enable old IT suites for iceberg tables #917
Conversation
sfc-gh-alhuang
requested review from
sfc-gh-tzhang and
a team
as code owners
|
|
||
| /** Ingest large amount of rows. */ | ||
| @RunWith(Parameterized.class) | ||
| public class StreamingIngestBigFilesIT { | ||
| public abstract class BigFilesITBase { |
There was a problem hiding this comment.
Yes it's passing with the JDBC uploader. The max chunk size in this test is 19MB.
|
|
||
| @Parameter public String compressionAlgorithm; | ||
| @Parameter(1) | ||
| public Constants.IcebergSerializationPolicy icebergSerializationPolicy; |
There was a problem hiding this comment.
lets remove the runwith parameterized from the base class, and remove the parameter annotations from here too. Makes class design murky.
Let the derived classes have the runwith and the @parameter, and pass in the values via beforeAll.
I'm also debating the value of running this IT for iceberg when you've already authored a much better large file test thats in my PR rn.
There was a problem hiding this comment.
clearly its not exercising multipart upload, if it was iceberg tests would've failed.
There was a problem hiding this comment.
Removed this IT and use the on with larger file size for Iceberg streaming.
sfc-gh-alhuang
force-pushed
the
alhuang-iceberg-ITs
branch
from
9448f1c to
160c4dc
Compare
Enable all remaining FDN only ITs for Iceberg table streaming.