Support JSON Schema converter #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source uses `io.confluent.connect.json.JsonSchemaConverter`, there is no suitable converter for snowflake sink. Adding it.
GSokol
requested review from
sfc-gh-japatel,
sfc-gh-tzhang,
sfc-gh-tjones and
sfc-gh-rcheng
as code owners
|
👋 @sfc-gh-japatel @sfc-gh-tzhang @sfc-gh-tjones @sfc-gh-rcheng Could I get a review, please? Thanks! 😊 |
|
Hi, thanks for waiting. We have a similar PR #518 |
|
Hi @GSokol, do you need any help with this PR, or can it be closed? |
|
Hi, @sfc-gh-achyzy, so is that functionality somehow in? Could I land messages, produced by confluent json converter (which starts messages with magic byte https://github.com/confluentinc/schema-registry/blob/master/json-schema-serializer/src/main/java/io/confluent/kafka/serializers/json/AbstractKafkaJsonSchemaSerializer.java#L162)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source uses
io.confluent.connect.json.JsonSchemaConverter, there is no suitable converter for snowflake sink. Adding it.