SNOW-1058245-sqlalchemy-20-support: code review fixes

src/snowflake/sqlalchemy/compat.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import functools
-import warnings
 from typing import Callable
 
 from sqlalchemy import __version__ as SA_VERSION
@@ -30,36 +29,8 @@ def wrapper(*args):
                 reduced_args = tuple(
                     arg for idx, arg in enumerate(args) if idx not in positions_to_drop
                 )
-                warnings.warn(
-                    "This needs refactoring", DeprecationWarning, stacklevel=2
-                )
             fn(*reduced_args)
 
         return wrapper
 
     return fn_wrapper
-
-
-def args_filler(positions_to_insert: tuple):
-    """This method inserts into args values at positions.
-
-    positions_to_insert is a tuple of tuple containing pair of posiotion and a value.
-    ((6, False), (7, 42))
-    It will insert at position 6 value False, and at positoin 6 value 42.
-    """
-
-    def fn_wrapper(fn: Callable):
-        @functools.wraps(fn)
-        def wrapper(*args):
-            extended_args = list(args)
-            if IS_VERSION_20:
-                for idx, value in positions_to_insert:
-                    extended_args.insert(idx, value)
-                warnings.warn(
-                    "This needs refactoring", DeprecationWarning, stacklevel=2
-                )
-            fn(*extended_args)
-
-        return wrapper
-
-    return fn_wrapper

tests/conftest.py

@@ -156,7 +156,6 @@ def get_engine(url: URL, **engine_kwargs):
     return engine
 
 
-# @pytest.fixture(scope="session")
 @pytest.fixture()
 def engine_testaccount(request):
     url = url_factory()
@@ -165,7 +164,6 @@ def engine_testaccount(request):
     yield engine
 
 
-# @pytest.fixture(scope="session")
 @pytest.fixture()
 def engine_testaccount_with_numpy(request):
     url = url_factory(numpy=True)
@@ -174,7 +172,6 @@ def engine_testaccount_with_numpy(request):
     yield engine
 
 
-# @pytest.fixture(scope="session")
 @pytest.fixture()
 def engine_testaccount_with_qmark(request):
     snowflake.connector.paramstyle = "qmark"