Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback to NullType when dialect type not found #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix fallback to NullType when dialect type not found #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions snowdialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,7 @@ def _get_schema_columns(self, connection, schema, **kw):
(sqltypes.String, sqltypes.BINARY)):
col_type_kw['length'] = character_maximum_length

type_instance = col_type(**col_type_kw)

type_instance = col_type if isinstance(col_type, sqltypes.NullType) else col_type(**col_type_kw)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need the same change at line 453

current_table_pks = schema_primary_keys.get(table_name)

ans[table_name].append({
Expand Down