SNOW-857216: fix compatibility issue with sqlalchemy 1.4.49 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aling
commented
Jul 6, 2023
sfc-gh-aling
commented
Jul 6, 2023
Comment on lines
+379
to
+385
| try: | ||
| replacement = self.process(binary.modifiers["replacement"], **kw) | ||
| except KeyError: | ||
| # in sqlalchemy 1.4.49, the internal structure of the expression is changed | ||
| # that binary.modifiers doesn't have "replacement": | ||
| # https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-1.4.49 | ||
| return f"REGEXP_REPLACE({string}, {pattern}{'' if flags is None else f', {flags}'})" |
There was a problem hiding this comment.
we don't need extra test as it is covered by the sqlalchemy_test_suites
sfc-gh-aling
deleted the
SNOW-857216-sql-alchemy-compatibility-issue-with-1-4-49
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-857216
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.