Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-897870: remove connector submodule in sqlalchemy #442

Merged
merged 2 commits into from
Aug 23, 2023
Merged

SNOW-897870: remove connector submodule in sqlalchemy #442

merged 2 commits into from
Aug 23, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Aug 22, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-897870: remove connector submodule in sqlalchemy

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-mkeller
sfc-gh-mkeller approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aling sfc-gh-aling changed the title SNOW-897872: update submodule SNOW-897870: remove connector submodule in sqlalchemy Aug 22, 2023
@sfc-gh-aling sfc-gh-aling merged commit 67f4152 into main Aug 23, 2023
15 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-897872-update-sqlalchemy-submodule branch August 23, 2023 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

@sfc-gh-kdama sfc-gh-kdama Awaiting requested review from sfc-gh-kdama

@sfc-gh-stan sfc-gh-stan Awaiting requested review from sfc-gh-stan

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-mkeller