Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1212541-ordered-sequence: add support for creating sequences order #473

Merged
merged 4 commits into from
Mar 11, 2024
Merged

SNOW-1212541-ordered-sequence: add support for creating sequences order #473

merged 4 commits into from
Mar 11, 2024

Conversation

sfc-gh-mraba
Copy link
Collaborator

@sfc-gh-mraba sfc-gh-mraba commented Mar 6, 2024 •
edited
Loading

…order

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #1212541

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
    • I am fixing tests for sequences failing due to BCR 2024_01 and sequence behaviour changes

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Following files were reformatted due to pre-commit config update

  • src/snowflake/sqlalchemy/custom_commands.py
  • src/snowflake/sqlalchemy/snow_dialect.py
  • src/snowflake/sqlalchemy/util.py

@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review March 7, 2024 11:10
@sfc-gh-mraba sfc-gh-mraba enabled auto-merge (squash) March 7, 2024 11:17
@sfc-gh-mraba sfc-gh-mraba requested a review from a team March 11, 2024 11:49
@sfc-gh-mraba sfc-gh-mraba self-assigned this Mar 11, 2024
sfc-gh-astus
sfc-gh-astus reviewed Mar 11, 2024
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
@sfc-gh-mraba sfc-gh-mraba merged commit f384432 into main Mar 11, 2024
12 of 15 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1212541-ordered-sequences branch March 11, 2024 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mraba @sfc-gh-astus