Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1324105-dependency-pinning: move versions pinning from project env to metadata #486

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

sfc-gh-mraba
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1324105: ImportError: cannot import name 'string_types' from 'sqlalchemy.util.compat' due to latest SQLAlchemy version #485

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Moved SQLAlchemy version pinning from env settings to project metadata.
    Added CI job for build and installation validation.

@sfc-gh-mraba sfc-gh-mraba self-assigned this Apr 15, 2024
@sfc-gh-mraba sfc-gh-mraba requested a review from a team April 15, 2024 11:50
@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review April 15, 2024 11:50
@sfc-gh-mraba sfc-gh-mraba merged commit 8ea9ab9 into main Apr 15, 2024
35 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1324105-dependency-pinning branch April 15, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants