Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pypa/gh-action-pypi-publish to fix deployment issue #519

Conversation

edgarrmondragon
Copy link

@edgarrmondragon edgarrmondragon commented Jul 9, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Relates to SNOW-739749: snowflake-sqlalchemy 1.4.4 requires sqlalchemy<2.0.0,>=1.4.0, but you have sqlalchemy 2.0.1 which is incompatible. #380 and Snow 1058245 SqlAlchemy 2.0 support #469

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This fixes the PyPI publishing step by bumping the pypa/gh-action-pypi-publish
    action to the latest tag (v1.9.0).

    You can see the failure in
    https://github.com/snowflakedb/snowflake-sqlalchemy/actions/runs/9845961499/job/27182670129:

    InvalidDistribution: Metadata is missing required fields: Name,        
          Version.                                                               
          Make sure the distribution includes the files where those fields are   
          specified, and is using a supported Metadata-Version: 1.0, 1.1, 1.2,   
          2.0, 2.1, 2.2.
    

    See build(deps): bump pkginfo version to support Metadata-version=2.3 pypa/gh-action-pypi-publish#219 and
    https://discuss.python.org/t/status-or-funding-for-metadata-2-2-in-pypi/46137/36 for
    more details.

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner July 9, 2024 07:14
Copy link

github-actions bot commented Jul 9, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@edgarrmondragon
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@edgarrmondragon
Copy link
Author

I guess closing this in favor of #520

@edgarrmondragon edgarrmondragon deleted the bump-gh-action-pypi-publish branch July 9, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant