Adding support for snowflake dynamic tables to SqlAlchemy Core #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/snowflake/sqlalchemy/sql/custom_schema/options/target_lag.py
Outdated
Show resolved
Hide resolved
src/snowflake/sqlalchemy/sql/custom_schema/options/target_lag.py
Outdated
Show resolved
Hide resolved
src/snowflake/sqlalchemy/sql/custom_schema/options/target_lag.py
Outdated
Show resolved
Hide resolved
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
sfc-gh-mraba
approved these changes
Oct 2, 2024
sfc-gh-jvasquezrojas
force-pushed
the
support_for_dynamic_table
branch
from
7a95bb4
to
2475f60
Compare
sfc-gh-mraba
approved these changes
Oct 2, 2024
Co-authored-by: Marcin Raba <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1514024
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add new table type DynamicTable with its required clauses As query, target lag and warehouse to Snowflake SqlAlchemy Core.
At this time, this PR does not introduce additional support for dynamic tables in reflection and ORM. However, dynamic tables can still be utilized within these contexts.
Document explanatory: https://docs.google.com/document/d/10rK82HodY9CrLUOZUDevJHo_xPtzRlske-gx0xxqZVQ/edit