Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return value of snowflake get_table_names #564

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix return value of snowflake get_table_names #564

merged 3 commits into from
Jan 6, 2025

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Dec 21, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.
    This PR has been duplicated to execute the necessary tests and merge the changes. For reference, the original PR can be found here: #563.
    Co-authored by @TrangPham

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner December 21, 2024 01:27
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit d84484e into main Jan 6, 2025
47 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the fix-get-table-names branch January 6, 2025 01:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas linked an issue Jan 10, 2025 that may be closed by this pull request
SNOW-1871391: SnowflakeDialect get_table_names is now returning dict_keys breaks compatibility #566
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-lcalderonachio sfc-gh-lcalderonachio sfc-gh-lcalderonachio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1871391: SnowflakeDialect get_table_names is now returning dict_keys breaks compatibility
3 participants
@sfc-gh-jvasquezrojas @sfc-gh-lcalderonachio @TrangPham