Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1855916 Add support for Python 3.12 #47

Closed
wants to merge 2 commits into from
Closed

SNOW-1855916 Add support for Python 3.12 #47

wants to merge 2 commits into from

Conversation

sfc-gh-sili
Copy link
Collaborator

No description provided.

@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner December 12, 2024 22:59
@sfc-gh-sili sfc-gh-sili changed the title SNOW-1007333 Add support for Python 3.12 SNOW-1855916 Add support for Python 3.12 Dec 12, 2024
sfc-gh-jopel
sfc-gh-jopel approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jopel sfc-gh-jopel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update the changelog?

@sfc-gh-sili
Copy link
Collaborator Author

should we update the changelog?

Thank you, Jeevan! I'll save changelog update for the next release.

sfc-gh-tmonk
sfc-gh-tmonk approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-tmonk sfc-gh-tmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sfc-gh-sili
Copy link
Collaborator Author

Closing the PR since it accomplished its mission

@sfc-gh-sili
Copy link
Collaborator Author

@sfc-gh-tmonk
Copy link
Collaborator

@sfc-gh-sili We should merge this one to master. The one that doesn't need to be merged is the one that is intended for the v0.5.x release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jopel sfc-gh-jopel sfc-gh-jopel approved these changes

@sfc-gh-tmonk sfc-gh-tmonk sfc-gh-tmonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-sili @sfc-gh-tmonk @sfc-gh-jopel