Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SNOW-1347394: Remove BaseQueryCompiler + error in QC default to pandas (
#1454) Please answer these questions before submitting your pull requests. Thanks! 1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR. Fixes SNOW-1347394 2. Fill out the following pre-review checklist: - [ ] I am adding a new automated test(s) to verify correctness of my new code - [ ] I am adding new logging messages - [ ] I am adding a new telemetry message - [ ] I am adding new credentials - [ ] I am adding a new dependency 3. Please describe how your code solves the related issue. This PR removes our vendored copy of the `BaseQueryCompiler` class, inheriting the class from upstream Modin instead. Similarly, it removes all the operator registration classes defined in `snowflake.snowpark.modin.core.dataframe.algebra.default2pandas`, with one exception. Upstream Modin does not properly render the names of `property` objects (modin-project/modin#7233), so we should override `DataFrameDefault.register` to fix this until this issue is fixed upstream. This PR incidentally removes `Series.dt.week` + `Series.dt.weekofyear`, which were already removed in pandas 2.0. --------- Co-authored-by: Naren Krishna <[email protected]>
- Loading branch information