SNOW-956848 Store underlying error in SnowparkSQLException #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-956848-error
branch
4 times, most recently
from
2268924 to
c772e7c
Compare
sfc-gh-bchinn
commented
Nov 2, 2023
Comment on lines
-242
to
+255
| f"DataFrame alias unrecognized. A subset of columns corresponding to Dataframe alias '{alias}' can not be found. " | ||
| "1208", | ||
| f"DataFrame alias unrecognized. A subset of columns corresponding to Dataframe alias '{alias}' can not be found. ", | ||
| error_code="1208", |
There was a problem hiding this comment.
😱 This almost makes me wish Python didn't allow implicit string concatenation
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-956848-error
branch
from
c772e7c to
10fd7cd
Compare
sfc-gh-aalin
approved these changes
Nov 2, 2023
|
Adding @sfc-gh-aling as a reviewer since I'm not a code owner. It looks like the two of us had the same idea :) |
sfc-gh-sfan
approved these changes
Nov 3, 2023
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-956848-error
branch
from
10fd7cd to
b07de12
Compare
|
@sfc-gh-yixie @sfc-gh-sfan can one of you merge? |
|
There is a CLA bot thingy that I'll check with the team and see what to do about it. |
|
@sfc-gh-sfan any updates on this? |
sfc-gh-aalam
reviewed
Nov 9, 2023
sfc-gh-aalam
approved these changes
Nov 9, 2023
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-956848-error
branch
from
b07de12 to
28b9541
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-956848-error
branch
from
28b9541 to
67c4c01
Compare
|
@sfc-gh-aalin @sfc-gh-sfan Can one of you merge? I don't have write access |
Alas, neither do I |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
https://snowflakecomputing.atlassian.net/browse/SNOW-956848
This is mostly addressed by SNOW-947875 Add sql_error_code and raw_message into SnowparkSQLException #1111, but I think this is a better long-term solution, for the user to have access to any information in the underlying error.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.