Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-956848 Store underlying error in SnowparkSQLException #1122

Merged
merged 8 commits into from
Nov 16, 2023
+115 −90
Merged

SNOW-956848 Store underlying error in SnowparkSQLException #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c5aa23
Refactor: Use getattr instead of __getattribute__
sfc-gh-bchinn Nov 1, 2023
3591413
Bugfix: Fix bad constructor
sfc-gh-bchinn Nov 1, 2023
8cc8df0
Refactor: Use kwargs instead of specifying None for sfqid
sfc-gh-bchinn Nov 1, 2023
c25b959
Refactor: Specify exception parameters as kwargs
sfc-gh-bchinn Nov 1, 2023
2b78bc0
Refactor: Force exception args to be passed as kwargs
sfc-gh-bchinn Nov 1, 2023
d347bc2
Refactor: Reuse SnowparkClientException.__init__ in SnowparkSQLException
sfc-gh-bchinn Nov 1, 2023
166abfe
Store snowflake-connector-python error in SnowflakeSQLException
sfc-gh-bchinn Nov 1, 2023
67c4c01
Expand tests
sfc-gh-bchinn Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## 1.10.1 (TBD)

### New Features

- Add the `conn_error` attribute to `SnowflakeSQLException` that stores the whole underlying exception from `snowflake-connector-python`

### Bug Fixes

- DataFrame column names qouting check now supports newline characters.
Expand Down
4 changes: 1 addition & 3 deletions src/snowflake/snowpark/_internal/analyzer/snowflake_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ def wrap(*args, **kwargs):
try:
return func(*args, **kwargs)
except snowflake.connector.errors.ProgrammingError as e:
query = None
if "query" in e.__dict__:
query = e.__getattribute__("query")
query = getattr(e, "query", None)
tb = sys.exc_info()[2]
assert e.msg is not None
if "unexpected 'as'" in e.msg.lower():
Expand Down
Loading
Loading