SNOW-1018660: use split_blocks=True by default #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
approved these changes
Feb 1, 2024
sfc-gh-aling
approved these changes
Feb 5, 2024
I forgot to push the changelog. Updated now |
sfc-gh-jrose
approved these changes
Feb 5, 2024
sfc-gh-yixie
reviewed
Feb 5, 2024
CHANGELOG.md
Outdated
| @@ -3,14 +3,13 @@ | |||
| ## 1.13.0 (TBD) | |||
|
|
|||
| ### New Features | |||
|
|
|||
| - Use `split_blocks=True` by default during `to_pandas` conversion for optimal memory allocation. | |||
There was a problem hiding this comment.
Better tell people what this parameter is about. Most users don't know what it is.
There was a problem hiding this comment.
added more details
sfc-gh-yixie
approved these changes
Feb 7, 2024
sfc-gh-aalam
deleted the
aalam-SNOW-1018660-set-split_block-to-True-by-default
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-1018660
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Setting
split_blocks=Trueuntil we get a resolution for default case. This also aligs with the recommendation from pyarrow maintainers.