Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1018660: use split_blocks=True by default #1234

Merged
merged 8 commits into from
Feb 7, 2024
Merged

SNOW-1018660: use split_blocks=True by default #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f82b0b4
use split_blocks=True by default
sfc-gh-aalam Feb 1, 2024
9f81be9
changelog updates
sfc-gh-aalam Feb 2, 2024
2a7424d
Merge branch 'main' into aalam-SNOW-1018660-set-split_block-to-True-b…
sfc-gh-aalam Feb 5, 2024
479ad79
more details in changelog
sfc-gh-aalam Feb 5, 2024
1b2d879
fix grammar
sfc-gh-aalam Feb 5, 2024
60a8604
Merge branch 'main' into aalam-SNOW-1018660-set-split_block-to-True-b…
sfc-gh-aalam Feb 7, 2024
06462af
fix changelog
sfc-gh-aalam Feb 7, 2024
3293110
revert to minimal changelog
sfc-gh-aalam Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

### New Features

- Use `split_blocks=True` by default during `to_pandas` conversion for optimal memory allocation. This parameter is passed to `pyarrow.Table.to_pandas` that enables `PyArrow` to split the memory allocation into smaller, more manageable blocks instead of allocating a single contiguous block thus giving better memory management when dealing with larger datasets.

### Bug Fixes

- Fixed a bug in `DataFrame.to_pandas` that caused an error when evaluating on a dataframe with an IntergerType column with null values.
Expand Down
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/_internal/server_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,11 +451,11 @@ def _to_data_or_iter(
functools.partial(
_fix_pandas_df_fixed_type, results_cursor=results_cursor
),
results_cursor.fetch_pandas_batches(),
results_cursor.fetch_pandas_batches(split_blocks=True),
)
if to_iter
else _fix_pandas_df_fixed_type(
results_cursor.fetch_pandas_all(), results_cursor
results_cursor.fetch_pandas_all(split_blocks=True), results_cursor
)
)
except NotSupportedError:
Expand Down
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/mock/_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,11 @@ def _to_data_or_iter(
functools.partial(
_fix_pandas_df_fixed_type, results_cursor=results_cursor
),
results_cursor.fetch_pandas_batches(),
results_cursor.fetch_pandas_batches(split_blocks=True),
)
if to_iter
else _fix_pandas_df_fixed_type(
results_cursor.fetch_pandas_all(), results_cursor
results_cursor.fetch_pandas_all(split_blocks=True), results_cursor
)
)
except NotSupportedError:
Expand Down
Loading