Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-938998: reenable gcp tests after packages are ready #1090

Merged
merged 1 commit into from
Oct 16, 2023
Merged

SNOW-938998: reenable gcp tests after packages are ready #1090

merged 1 commit into from
Oct 16, 2023

Conversation

sfc-gh-aling
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-938998

GCP deployment now has the packages ready

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner October 16, 2023 15:58
@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 16, 2023
@sfc-gh-aling sfc-gh-aling merged commit 5a01033 into main Oct 16, 2023
50 of 51 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-938998-enable-python-3-11-gcp-tests-on-merge-gateg branch October 16, 2023 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aling @sfc-gh-stan @sfc-gh-sfan