Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daydiff documentation #1113

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix daydiff documentation #1113

merged 1 commit into from
Oct 27, 2023

Conversation

sfc-gh-aalam
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-952961: Wrong documentation for daydiff function #1112

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Minor documentation update to match the functionality.

@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner October 27, 2023 17:51
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) October 27, 2023 17:51
@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 27, 2023
@sfc-gh-aalam sfc-gh-aalam merged commit 467028c into main Oct 27, 2023
51 of 52 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-952961-wrong-documentation-for-daydiff-function branch October 27, 2023 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-bwarsaw sfc-gh-bwarsaw Awaiting requested review from sfc-gh-bwarsaw sfc-gh-bwarsaw was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-952961: Wrong documentation for daydiff function
4 participants
@sfc-gh-aalam @sfc-gh-stan @sfc-gh-sfan @sfc-gh-aling