Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-976704 : Adding lead and lag dataframe function #1147

Merged
merged 60 commits into from
Jan 31, 2024
Merged

SNOW-976704 : Adding lead and lag dataframe function #1147

merged 60 commits into from
Jan 31, 2024

Conversation

sfc-gh-rsureshbabu
Copy link
Collaborator

@sfc-gh-rsureshbabu sfc-gh-rsureshbabu commented Nov 23, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-976704

The PR is adding the lead and lag functions as proposed in https://docs.google.com/document/d/14J5lr_a3fE1xeU-YzKWdeduBdC_035sry11lJUjjkT8/edit

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-rsureshbabu
changes
6840bfd
@sfc-gh-rsureshbabu
updating changelog
266a281
@sfc-gh-rsureshbabu
fixing comment
2499a6d
@sfc-gh-rsureshbabu
generalizing default formatter
4ba1a64
@sfc-gh-rsureshbabu
generalizing default formatter 2
810bfb8
@sfc-gh-rsureshbabu
fix comment
b43ffec
@sfc-gh-rsureshbabu
changes
adca1de
@sfc-gh-rsureshbabu
cleaning argument checks
5a007b2
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
2d574b7 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
cleaning argument checks
91ff442
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
bd0bf2a 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
cleaning argument checks
f66d519
@sfc-gh-rsureshbabu
refactor
faccd9b
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
9622651 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
changes
f5b0040
@sfc-gh-rsureshbabu
changes
e27f0ea
@sfc-gh-rsureshbabu
changes
cc4713a
@sfc-gh-rsureshbabu
changes
c5ff590
@sfc-gh-rsureshbabu
fix test
e8d4345
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
3427e27 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
changes
249b384
@sfc-gh-rsureshbabu
changes
ccf6655
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
919e1c8 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
changes
eef9062
@sfc-gh-rsureshbabu
changes
8e7adad
@sfc-gh-rsureshbabu
Merge branch 'rsureshbabu-SNOW-SNOW-976701-movingagg' into rsureshbabu-…
1d0b265 
…SNOW-976704-leadlagfunctions
@sfc-gh-rsureshbabu
changes
d3a8b6b
@sfc-gh-rsureshbabu
changes
dff89e5
@sfc-gh-rsureshbabu
changes
f8e0fc7
@sfc-gh-rsureshbabu
changes
9a9a045
sfc-gh-sfan
sfc-gh-sfan reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some doc test to serve as example

Base automatically changed from rsureshbabu-SNOW-SNOW-976701-movingagg to main January 25, 2024 00:15
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu enabled auto-merge (squash) January 31, 2024 18:08
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu merged commit 3cc1e70 into main Jan 31, 2024
57 checks passed
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu deleted the rsureshbabu-SNOW-976704-leadlagfunctions branch January 31, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-wezhou sfc-gh-wezhou sfc-gh-wezhou approved these changes

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-bwarsaw sfc-gh-bwarsaw Awaiting requested review from sfc-gh-bwarsaw sfc-gh-bwarsaw was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-sfan sfc-gh-sfan Awaiting requested review from sfc-gh-sfan

@sfc-gh-tbao sfc-gh-tbao Awaiting requested review from sfc-gh-tbao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-rsureshbabu @sfc-gh-yixie @sfc-gh-sfan @sfc-gh-wezhou @sfc-gh-tbao